Repository navigation
chore(deps): bump Biome to 2.6.2 and pin the Dependabot sweep versions - #145
Merged
Merged
Conversation
…matting off Biome 2.6 formats Markdown and YAML by default, which would rewrite 176 docs, skill and issue-template files. This upgrade is behaviour-neutral: markdown.formatter.enabled and yaml.formatter.enabled are false, so turning them on is a separate decision. The 2.6 CSS formatter indents nested selector lists one level deeper (three starter stylesheets), and noComponentHookFactories joined the recommended set, so the Filters helper in packages/ui's schedules test moves to module level. The new useMathMinMax rule adds seven warnings; pnpm check reads errors only. Also: AGENTS.md, ADR-0006, ADR-0012 and code-structure.md pin the versions the Dependabot sweep landed (Biome 2.6, jsonschema 0.60, wrangler 4.152, @astrojs/cloudflare 14.4), with a changeset for the published packages that depend on wrangler and @astrojs/cloudflare. Supersedes #137. Co-Authored-By: Claude Fable 5.1 <[email protected]> Signed-off-by: Madraka <[email protected]>
Dependabot's #139 (14.4.2) fails after its rebase: the regenerated lockfile resolves @cloudflare/vite-plugin 1.67.0, whose peer range is wrangler ^4.156.1, while main is on 4.152.0. AGENTS.md, ADR-0012 and the changeset now describe what is on main. Co-Authored-By: Claude Fable 5.1 <[email protected]> Signed-off-by: Madraka <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces Dependabot's #137 (
@biomejs/biome2.5.15 → 2.6.2, the dev-tooling group), which failedpnpm lintwith 176 "Formatter would have printed" errors: Biome 2.6 formats Markdown and YAML by default, and 2.5 never touchedCODE_OF_CONDUCT.md,docs/,.agents/skills/or.github/ISSUE_TEMPLATE/*.yml.This PR keeps the upgrade behaviour-neutral:
biome.json:$schema→ 2.6.2;markdown.formatter.enabled: falseandyaml.formatter.enabled: false. Turning Markdown/YAML formatting on is a separate decision (it rewrites ~170 files, mostly prose wrapping and list markers).starters/blog/src/styles/features/{chrome-menus,motion,surfaces}.css), whitespace only.noComponentHookFactoriesjoined the recommended set: theFiltershelper component inpackages/ui/test/schedules.test.tsxmoves from inside thedescribeto module level (test-only).useMathMinMaxadds 7 warnings (pnpm lintnow 442 warnings vs 435 on 2.5.15; 0 errors either way;pnpm checkruns with--diagnostic-level=error, so unaffected).Also pins the versions the Dependabot sweep landed on main (#138, #140, #141, #142):
AGENTS.mdVersions line (Biome 2.6, jsonschema 0.60, wrangler 4.152), ADR-0006, ADR-0012,docs/engineering/code-structure.md, plus.changeset/deps-2026-11.mdfor@cloudhal/astro-renderer,@cloudhal/cliand@cloudhal/cloudflare(wrangler is their dependency).@astrojs/cloudflarestays at 14.3.4: #139 (14.4.2) fails after its rebase because the regenerated lockfile resolves@cloudflare/vite-plugin1.67.0, whose peer range is wrangler^4.156.1, while main has 4.152.0. It needs a wrangler bump (latest 4.158.0) first; ADR-0012 notes this.Verified locally:
pnpm lint(0 errors),pnpm typecheck,pnpm design:lint(400 files clean). Tests run in CI only (per the owner's request, no local test suites while other sessions are running).Checklist
pnpm checkandcargo test --workspacepass locally — relying on CI (lint, typecheck and design lint pass locally)pnpm genwas run and generated files are committed (docs/adr/0001) — n/apnpm changesetaddedgit commit -s, DCO)🤖 Generated with Claude Code